microsoft / microsoft/sqlmanagementobjects
Replace type-aware factory methods in ObjectKeyBase with collection instance methods
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 143
- Forks
- 28
- PR merge metrics
- No merged PRs in 30d
Description
GetFieldNames and CreateKeyOffset can likely be replaced with a set of abstract/virtual methods in the collection hierarchy because each collection instance knows the type of its member. Address this issue after completing #130
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with SmoCollectionBase.cs around line 638 and inspect ObjectKeyBase, including GetFieldNames and CreateKeyOffset and the surrounding collection hierarchy. First complete issue #130, then determine how each collection instance can provide these operations; done means the type-aware factory methods are replaced by collection instance methods across the hierarchy.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100