microsoft / microsoft/sql-server-samples

Duplicated Row-Level-Security predicate in WWI

Open
#451 0 comments 0 reactions 5 assignees View on GitHub

@ajay-msft is already working on this.

Since Oct 5, 2018.

Dominant language
PowerShell
Stars
11.2k
Forks
9.1k
Avg merge
2d 7h
Merged PRs (30d)
14

Description

Function DetermineCustomerAccess is placed both in:
https://github.com/Microsoft/sql-server-samples/blob/master/samples/databases/wide-world-importers/wwi-ssdt/wwi-ssdt/Application/Functions/DetermineCustomerAccess.sql

https://github.com/Microsoft/sql-server-samples/blob/master/samples/databases/wide-world-importers/wwi-ssdt/wwi-ssdt/Application/Stored%20Procedures/Configuration_ApplyRowLevelSecurity.sql

I'm not sure why it his done, but I have updated the code in one place but procedure is applied instead.

I guess that one of these two functions should be removed. By looking at history Jos committed this code.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.