microsoft / microsoft/sql-server-samples
SQL Assessment falsely flagging deprecated features in job steps
Nobody has claimed this yet.
- Dominant language
- PowerShell
- Stars
- 11.2k
- Forks
- 9.1k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 14
Description
Microsoft ruleset 1.0.305 has some checks against the commands column of msdb.dbo.sysjobsteps to see if deprecated code is used within the jobs. However, the code looks for at job steps that are both T-SQL and PowerShell.
...
AND sjs.[subsystem] IN ('TSQL','PowerShell');
We are seeing jobsteps that use the words 'load' or 'text' which are deprecated SQL features get flagged, but they are running PowerShell.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with samples/manage/sql-assessment-api/ruleset.json at lines 11570-11575 and inspect the checks against msdb.dbo.sysjobsteps.commands and subsystem. Reproduce the false positive with a PowerShell job step containing “load” or “text”; done means deprecated SQL features are checked without flagging matching text in PowerShell steps.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- powershell, sql
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100