microsoft / microsoft/semantic-kernel

.Net: Bug: Improve CreateAssistantFromTemplateAsync in AssistantClientExtensions

Open
#10,954 3 comments 0 reactions 1 assignee View on GitHub

@markwallace-microsoft is already working on this.

Since Mar 20, 2025.

.NET bug
Dominant language
C#
Stars
28.6k
Forks
4.8k
Avg merge
14h 13m
Merged PRs (30d)
18

Description

Describe the bug
the method CreateAssistantFromTemplateAsync has multiple input parameters which are already set in the PromptTemplateConfig . (ie : temperature , topP)
I think you can improve this method signature in order to reuse the promptTemplateConfig properties

Platform

  • Language: C#
  • Source: Lastest version
  • IDE: Visual Studio, VS Code
  • OS: Windows

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.