microsoft / microsoft/same-ish

Very close number not ish?

Open
#26 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
44
Forks
12
Avg merge
2d 17h
Merged PRs (30d)
2

Description

I am not understanding a lot on floating points, but it seems to me that these
2 should be "equal" for ish?:

(ish? 1798.4039776258396
         1798.4039776258326)

but they are not.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported (ish? 1798.4039776258396 1798.4039776258326) example and inspect the ish? entry point and its existing tests. Determine whether these values should compare as approximately equal, then add a regression test and confirm the comparison behavior matches the intended tolerance.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.