microsoft / microsoft/rust-symcrypt
Remove _ Prefix for datatypes from SymCrypt
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 72
- Forks
- 15
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 11
Description
There are places in the code where the _ prefix is used. I think the only reason that exists is because of historical quirks about how you used to have to use typedef struct in C. The non-underscore version is preferred, so if you have time it would be nice to clean the other occurrences up in a future PR, that would be nice.
_SYMCRYPT_NUMBER_FORMAT_SYMCRYPT_NUMBER_FORMAT_MSB_FIRST Ex:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue provides no file or test path. Search the repository for the underscore-prefixed SymCrypt datatype occurrences mentioned, compare them with the preferred non-underscore names, and confirm that all intended occurrences have been cleaned up.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, rust
- Domain
- cryptography
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100