microsoft / microsoft/retina

edge cases for MetricConfiguration CRD

Open
#74 5 comments 0 reactions 1 assignee Claimed by @roopeshsn View on GitHub
good first issue type/fix
Dominant language
Go
Stars
3.2k
Forks
304
Avg merge
1d 16h
Merged PRs (30d)
79

Description

If `enableAnnotations=false`, then advanced metrics won't show up unless a MetricConfiguration CRD exists (metric modules are initialized via metricModule's `Reconcile()`). We should initialize with default context options instead.

Also, should we support MetricConfiguration CRD when `enableAnnotations=true`? Right now, we do not:
https://github.com/microsoft/retina/blob/9248f0d140e5c93da77bdbdf5e43ea3b0029cfd4/controller/main.go#L254-L268

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.