AzBlob (and future OutputLocation) Config should be passed through ConfigMaps and Secrets
- Dominant language
- Go
- Stars
- 3.2k
- Forks
- 304
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 79
Description
**Is your feature request related to a problem? Please describe.**
Currently the AzBlob OutputLocation is provided via a [URL with an embedded SAS token](https://github.com/microsoft/retina/blob/29863599d5fa295fd59ae1baec21d108c5b7c907/crd/api/v1alpha1/capture_types.go#L139-L141). This URL is used as the `Volume` name in the Capture Pods that are created, which conveniently distributes the access credentials.
This is technically a credential leak - the SAS token is readable to anyone with `Pod:read` instead of `Secret:read`.
**Describe the solution you'd like**
The AzBlob config and secrets should be provided via Kubernetes objects for the same (ConfigMaps and Secrets).
**Additional context**
The rework done here should be portable to other (future) OutputLocation implementations such as S3 (#201)
Contributor guide
Assessment
This issue has not been assessed yet.