microsoft / microsoft/react-native-windows
Optimization suggestions for “ReactEventAttribute”
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Summary
The native events in the current version need to be marked with the attribute of “ReactEventAttribute”, and the method is a delegate. In fact, this can be completely defined as an event. I provide a sample project to illustrate this implementation, and hope it can be adopted
Motivation
Using event to do events can more intuitively express events and be closer to the development and coding habits of programmers. This optimization will not help the essence of the project, but will be more friendly in the way of implementation
Basic Example
I provided a sample project at the following address:
https://github.com/527395632/DynamicEvent/tree/main/ConsoleApp1
Open Questions
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the native event definitions that use ReactEventAttribute and delegate methods; the issue does not name repository files or tests. Compare the current implementation with the linked DynamicEvent sample, then determine the affected event declarations and callers. Done means the proposed event-based implementation is integrated without changing event behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100