microsoft / microsoft/react-native-windows
Microsoft.googletest doesn't have INSTANTIATE_TEST_SUITE_P
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Problem Description
Latest integrations brought a commit that switches from INSTANTIATE_TEST_CASE_P to INSTANTIATE_TEST_SUITE_P in googletests. https://github.com/facebook/react-native/commit/12a32549f427c993637d41569c49baf5ab7113e8. This causes us to fork ReactCommon/jsi/jsi/test/testlib.cpp.
It looks like Meta switched to googletest version 1.10 while we're on https://github.com/Microsoft/TestAdapterForGoogleTest 1.8.1 (I don't think the latest version has INSTANTIATE_TEST_SUITE_P)
Errors:

Steps To Reproduce
- Remove ReactCommon/jsi/jsi/test/testlib.cpp override
- Try and build Microsoft.ReactNative.sln
Expected Results
No response
CLI version
7.0.3
Environment
System:
OS: Windows 10 10.0.22000
CPU: (8) x64 Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz
Memory: 42.05 GB / 63.85 GB
Binaries:
Node: 14.17.5 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 8.6.0 - C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK: Not Found
Windows SDK:
AllowDevelopmentWithoutDevLicense: Enabled
AllowAllTrustedApps: Enabled
Versions: 10.0.17763.0, 10.0.18362.0, 10.0.19041.0, 10.0.22000.0
IDEs:
Android Studio: Not Found
Visual Studio: 16.11.32228.343 (Visual Studio Enterprise 2019)
Languages:
Java: 1.8.0_302 - C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin\javac.EXE
npmPackages:
@react-native-community/cli: Not Found
react: Not Found
react-native: Not Found
react-native-windows: Not Found
npmGlobalPackages:
*react-native*: Not Found
Target Platform Version
No response
Target Device(s)
Desktop
Visual Studio Version
Visual Studio 2019
Build Configuration
No response
Snack, code example, screenshot, or link to a repository
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ReactCommon/jsi/jsi/test/testlib.cpp and the Microsoft.ReactNative.sln build. Remove the testlib.cpp override and reproduce the GoogleTest macro error using the reported Windows and Visual Studio setup. Done means the solution builds without the fork while the tests use a macro supported by the configured Microsoft Test Adapter version.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100