microsoft / microsoft/react-native-windows
Remove explicit imports of RNW props/targets when consuming RNW from NuGet
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Now that we have PackageReference for C++ and C#, we can probably remove the need for explicit Imports of the RNW props/targets when consuming from NuGet (like in the winappsdk case) and have the project system include the props/targets automatically.
We'd still need to import them when building from source though.
Originally posted by @asklar in https://github.com/microsoft/react-native-windows/pull/9177#discussion_r827644767
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the winappsdk case and the discussion in PR #9177, focusing on how RNW props/targets are imported for NuGet consumers versus source builds. Determine how PackageReference affects C++ and C# project-system imports. Done means NuGet consumption no longer needs explicit imports while source builds still do.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, csharp, react-native
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100