microsoft / microsoft/react-native-windows

Investigate if using pnpm breaks how we identify npm package versions

Open
#9,164 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area: CLI enhancement PR Follow-up Workstream: Developer Experience
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

In multiple places within our CLI we use a pattern of require.resolve('PACKAGENAME/package.json') to load an npm package's package.json file in order to get out a version number.

There's a concern that this might not work with certain package managers that put packages in directories that this won't find.

This would mean that using the RNW CLI would be broken in these package managers, so we should find out if that's the case.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the CLI uses of require.resolve('PACKAGENAME/package.json') and inspect how they obtain package versions. Reproduce the version lookup with pnpm and compare it with the package-manager setup the CLI currently supports. Done means establishing whether pnpm breaks these lookups and recording the needed follow-up if it does.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
cli, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.