microsoft / microsoft/react-native-windows
[RNWin32] Turn on enableFocusRing by default on View
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Summary
Switch enableFocusRing to be true by default (requires a native change. This issue is for tracking and making intent of behavior public, there should be no changes in the repo itself to implement this behavior.)
Motivation
RNWin32 has operated with mostly having clients implement their own focus UI through JS. With adding enableFocusRing in #9110 , in order to make sure that the new prop doesn't cause any issues on introduction, we are starting with the default to false, but want to transition to turning it on by default to align with other platforms long term. This issue is to track this intent.
Basic Example
No response
Open Questions
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the enableFocusRing introduction referenced in #9110 and identify where the native View default is defined. The issue says no repository changes are expected here; completion would require the native change that turns the default on and makes the behavior align with other platforms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100