microsoft / microsoft/react-native-windows

Add target to compare evaluation of property values post-build with values used by the CLI

Open
#8,758 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area: Build Infrastructure Area: CLI Area: Tests enhancement Workstream: Test Coverage
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

Summary

Add a new target at the end of an app build which exports the values of some select MSBuild properties. Compare those values against values used by the CLI and throw warnings if they don't match.

Motivation

We do various things in the CLI based on the values of MSBuild properties, and how we calculate those values might not match what values were actually used at build time. Adding a comparison at the end of the build will let us warn us and developers that the CLI either didn't calculate the values correctly, or that the developer overrode some value we didn't expect.

Basic Example

No response

Open Questions

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by locating the app-build targets and the CLI code that evaluates MSBuild properties, then determine which properties must be compared and how mismatches should be reported. Done means an end-of-build comparison exists and its warning behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, react-native
Domain
build-system, cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.