microsoft / microsoft/react-native-windows
Don't use non-Unicode functions to initialize V8 runtime holders
Open
@JunielKatarn is already working on this.
Since Aug 23, 2021.
Area: JavaScript Engine
enhancement
PR Follow-up
Workstream: Developer Experience
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
V8 and V8Napi runtime holder initialization relies on GetTempPathA to pass along the temporary prepared script store path.
Such function is not Unicode-compatible.
This is done because the underlying V8 API expects 8-bit character strings to handle the path value.
Determine whether to replace GetTempPathA's usage with an 8-bit Unicode (UTF-8) function.
don't use non-Unicode functions
Originally posted by @asklar in https://github.com/microsoft/react-native-windows/pull/8455#discussion_r693425363
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.