microsoft / microsoft/react-native-windows
Hermes profiler needs more work to function in win32 unpackaged apps
Open
@mganandraj is already working on this.
Since Aug 12, 2021.
Area: JavaScript Engine
enhancement
PR Follow-up
Workstream: Developer Experience
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
WINRT will still be defined though so I'm not sure that is the right fix. If WACK is failing because of the SHGetFolderPathW call, you can work around it by using CallIndirect<SHGetFolderPathW> (see https://github.com/microsoft/react-native-windows/blob/003602b90aeda1b2a43702c6a9307c0f01010e59/vnext/Microsoft.ReactNative.Cxx/DesktopWindowBridge.h)
Originally posted by @asklar in https://github.com/microsoft/react-native-windows/pull/8366#discussion_r685435719
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.