microsoft / microsoft/react-native-windows
Increase Clang Warning Level in OSS RN Build Logic
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
From discussion with @rozele:
Doing the work in BUCK is trickier, bc BUCK derives from multiple internal projects. Internal logic will also cover more than external.
Internal builds should be gated on OSS build breaks, so OSS build logic changes should be sufficient for preventing new warnings in OSS. This is something MSFT should be able to turn on in OSS.
We are mostly clean in files we use, so we could opt default + most existing usages in OSS to a higher warning level.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the OSS build logic in BUCK and identifying where Clang warning levels and existing OSS warning usages are configured. Review the discussion and current build behavior before deciding which higher default level is viable. Done means OSS builds reject newly introduced warnings without breaking existing supported files.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100