microsoft / microsoft/react-native-windows

Document IReactContext behavior for unloaded React instance

Open
#7,506 0 comments 0 reactions 1 assignee View on GitHub

@vmoroz is already working on this.

Since Apr 5, 2021.

Documentation: New or changed API enhancement PR Follow-up Workstream: Developer Experience
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

Not sure if possible, but it would be nice to show what it would look like or how to check if the weak pointer is unreferenced. And/or how to get it back.

We cannot dereference it because we never expose the wrapped up React instance. Though, the behavior of the IReactContext is going to change if we cannot dereference the React instance anymore. We need to document what will work or not work in such case.

Originally posted by @vmoroz in https://github.com/microsoft/react-native-windows/pull/7503#discussion_r605878471

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.