microsoft / microsoft/react-native-windows

Avoid comment duplication with a macro in JsiAbi.idl

Open
#7,505 0 comments 0 reactions 1 assignee View on GitHub

@vmoroz is already working on this.

Since Apr 5, 2021.

Area: JSI Code Cleanup enhancement PR Follow-up Workstream: Developer Experience
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

Since this is C++ can we use and reference a CONST with this string to not duplicate?

Good point! Though, this is not C++, but we should definitely be able to use to use a #define macro. Let me do it in another PR for master first and then port it to 0.64.

Originally posted by @vmoroz in https://github.com/microsoft/react-native-windows/pull/7503#discussion_r605875648

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.