microsoft / microsoft/react-native-windows
When is it safe to access JsiRuntime (need clear error and better documentation)
@vmoroz is already working on this.
Since Apr 3, 2021.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Currently Chakra does not allow accessing the jsi from a thread other than the JS thread. It's unclear whether the rest of the runtimes have the same restriction or not.
You can post a lambda to the m_reactContext.JSDispatcher(), we should document it beyond the API reference.
There should be diagnostics and docs for this, currently trying to access the runtime from the ui thread will terminate the app (instead of sending the exception back to app code)
It is also not clear that as a view manager e.g. it is not safe to try to access the jsi runtime from e.g. GetNativeProps - the runtime won't have been created yet
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.