microsoft / microsoft/react-native-windows
Make Touchable Text Changes strict-local clean
Open
Nobody has claimed this yet.
Code Cleanup
Deforking
enhancement
Workstream: Component Parity
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
https://github.com/facebook/react-native/commit/f275514f275fdc404a853a1a2ab46620eea484f0 increased the strictness used by the Flow type checker in Text.js. Touchable related changes in our version are not clean under new type checker settings.
For now we keep the file using lower strictness.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Text.js and compare the Touchable-related changes in this repository with commit f275514f275fdc404a853a1a2ab46620eea484f. Run the Flow checks using the stricter settings and confirm that Text.js no longer requires lower strictness.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100