microsoft / microsoft/react-native-windows
Replace node-rnw-rpc (automation-channel) throw to noexcept boundary with VerifyElseCrash
Open
Nobody has claimed this yet.
Area: Test Infrastructure
enhancement
PR Follow-up
Workstream: Test Coverage
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Should replace "throw to noexcept boundary" with VerifyElseCrash
Originally posted by @NickGerleman in https://github.com/microsoft/react-native-windows/pull/7071#discussion_r572626776
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the node-rnw-rpc automation-channel code and the existing throw-to-noexcept-boundary path. Replace that behavior with VerifyElseCrash, then run the relevant automation-channel or node-rnw-rpc tests if the repository provides them; done means the boundary no longer throws.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100