microsoft / microsoft/react-native-windows
Add more ReactNotificationService tests
Open
@vmoroz is already working on this.
Since Jan 21, 2021.
Area: Tests
enhancement
Workstream: Component Parity
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
We should have more IReactNotificationService tests, especially to test things like:
- subscribe, unsubscribe, subscribe
- nested notification services etc
- subscribing twice on the same node
- subscribing twice on sibblings and then unsubscribe.
- Error case for removing subscription twice?
Originally posted by @dannyvv in https://github.com/microsoft/react-native-windows/pull/6877#discussion_r557833233
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.