microsoft / microsoft/react-native-windows
Some JSI Unit Tests Fail
Open
@vmoroz is already working on this.
Since Jan 4, 2021.
Area: JavaScript Engine
bug
Workstream: Developer Experience
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
A small number of the tests imported from the Facebook JSI code base (i.e. node_modules\react-native\ReactCommon\jsi\jsi\test\testlib.cpp) fail deterministically.
Environment
Run the following in your terminal and copy the results here.
yarn
yarn build
cd vnext
nuget restore ReactWindows-Desktop.sln
- Build Configuration: x64|Debug
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.
- Build the test project.
msbuild .\ReactCommon.UnitTests\ - Run the tests.
vstest.console.exe --TestAdapterPath:"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\Extensions\ubawx25q.gzi" .\target\x64\Debug\ReactCommon.UnitTests\ReactCommon.UnitTests.exe
Expected Results
All tests pass successfully
Actual Results
The following tests fail:
- Building using V8 (default):
- Runtimes/JSITest.HostObjectProtoTest/0
- Runtimes/JSITest.HostFunctionTest/0
- Building using ChakraCore (
/p:UseV8=false):- Runtimes/JSITest.PreparedJavaScriptSourceTest/0
Workaround
These specific tests are explicitly disabled in CI/PR validations.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.