microsoft / microsoft/react-native-windows
Desktop dll hardcodes other libraries exports
Open
Nobody has claimed this yet.
bug
Code Cleanup
Platform: Desktop
Workstream: ES Compliance SFI
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
This is not only fragile because it's not guaranteed to be stable across compiler releases, but also whenever we take a new drop of a dependency (like folly), these exports are bound to change.
See:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing vnext/Desktop.DLL/react-native-win32.x64.def and vnext/Desktop.DLL/react-native-win32.x86.def, then trace how the Desktop.DLL build uses these export files. Check how dependency updates such as folly affect the listed exports. Done should mean the Desktop DLL no longer relies on fragile hardcoded exports from other libraries, with both architectures still building successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100