microsoft / microsoft/react-native-windows

Cryptic Errors When REACT_METHOD is not noexcept

Open
#5,936 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area: Native Modules enhancement Workstream: Module Support
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

If a method is marked as a REACT_METHOD, but isn't marked noexcept, we see the following string of errors after a template specialization failure.

image

We should either allow noexcept functions, or create a compile-time error with a clear message when a REACT_METHOD isn't noexcept.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the REACT_METHOD entry point and reproduce the template specialization failure with a method that is not noexcept. Trace the resulting diagnostics and determine whether the issue should support such functions or instead report a clear compile-time error; the work is done when the chosen behavior is covered and the cryptic error sequence is replaced.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, react-native
Domain
compilers, desktop-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.