microsoft / microsoft/react-native-windows
Native module dev experience problems
Open
@stmoy is already working on this.
Since Sep 8, 2020.
Area: Developer Experience
Area: Native Modules
bug
Workstream: Module Support
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Related: #5910
These are issues not related to "how to write" but still related to the dev experience of NM
- First build fails because something
#includesa Folly header but Folly hasn’t been downloaded yet. Some inter-project dependency isn’t properly declared.
A subsequent build succeeds, but this isn’t mentioned in the instructions either. - After creating the module solution, we say:
If you're writing in C++, you'll want to add Microsoft.ReactNative.Cxx:
(“…via the Shared projects tab”)
However that project does not show in the Shared projects tab. Continuing assuming this is not necessary. Is it?
Oh actually it shows up if I restart Visual Studio… - We should have a way to create the solution with the right references without requiring manual intervention
- The list of projects might need to be updated now that we’ve removed some Shared projects
- Instructions talk about creating an IDL file but doesn’t tell you how to in the VS UI
- Instructions mention to create a new app somewhere else and copy the windows folder over, can this be automated?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.