microsoft / microsoft/react-native-windows
Unfork TextExample page.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Looks like this is from the Android TextExample page.
The examples-win directory was mostly meant for custom windows examples, but TextExample was a bit special since long ago it was converted from Flow to Typescript, forked, and stopped being kept up to date. There we're a number of files like this that have kind of corroded by before we had tooling to automate three-way-merge of our forked changes.
Consider removing this fork of TextExample and adding back the Flow-based Android one (with any needed patching) to js/examples. That way it will be kept up to date automatically. ACoates and I have been opportunistically killing the Typescript forks of Flow files when we come across them, and have often found gaps when we do.
Originally posted by @NickGerleman in https://github.com/microsoft/react-native-windows/pull/5672
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the TextExample fork in examples-win with the Flow-based Android version in js/examples, starting with the existing example files and their differences. Remove the stale fork, restore the Android example with any required patching, and confirm the example is positioned for automatic updates.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100