microsoft / microsoft/react-native-windows
Bundle file with .jsbundle extension not found
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
When loading from embedded bundle, developer provides name of JavaScript bundle file in JavaScriptBundleFile method. Then .bundle extension is hardcoded to be appended to provided filename. That means that whenever bundle file has .jsbundle extension, it is not found.
Is it possible to add .JSBundleFileExtension() method to InstanceSettings, so developer can provide preferred bundle file extension which can be used instead of the hardcoded one?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in OInstance.cpp at the linked code around line 141, then locate InstanceSettings and the JavaScriptBundleFile method. Make the bundle extension configurable through the requested JSBundleFileExtension method, and verify that an embedded bundle using the .jsbundle extension can be found instead of relying on the hardcoded .bundle suffix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100