microsoft / microsoft/react-native-windows
Add ReactNotificationServiceHelper to Win32 ABI
Open
Nobody has claimed this yet.
Area: Core DLL
enhancement
Workstream: Component Parity
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Proposal: Add the 'ReactNotificationServiceHelper' class to the C++/WinRT ABI of the Win32 DLL
Summary
The ABI of the UWP DLL contains the 'ReactNotificationServiceHelper' class. We need to evaluate if this class is needed in the ABI of the Win32 and if so, add it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the UWP DLL ABI, where ReactNotificationServiceHelper already exists, with the Win32 DLL ABI and determine whether the class is required there. Done means documenting the decision and, if needed, adding the class to the Win32 C++/WinRT ABI with the corresponding validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- api, desktop
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100