microsoft / microsoft/react-native-windows
Group developer settings to simplify their use
Open
Nobody has claimed this yet.
Code Cleanup
enhancement
Workstream: Developer Experience
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
For the feedback by @dannyvv for PR #5071:
vnext/Microsoft.ReactNative.IntegrationTests/ReactNativeHostTests.cpp
host.InstanceSettings().UseDeveloperSupport(false);
host.InstanceSettings().UseWebDebugger(false);
host.InstanceSettings().UseFastRefresh(false);
host.InstanceSettings().UseLiveReload(false);
I've noticed that also in the template these are all set at the same time, should we have a single method to toggle these settings (in case we get more in the future) i.e.
UseDevSettings(true|false)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with vnext/Microsoft.ReactNative.IntegrationTests/ReactNativeHostTests.cpp and inspect how InstanceSettings currently applies the developer-related options. Compare this with the template usage mentioned in the issue; done means the grouped setting can toggle the listed developer settings together and the relevant tests or template usage reflect it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- developer-experience
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100