microsoft / microsoft/react-native-windows
Code Cleanup: Bundle.props can be moved into Bundle.targets
Open
A pull request for this has already been merged.
- #5416 by @dannyvv — merged
Area: Bundle
Code Cleanup
enhancement
Workstream: ES Compliance SFI
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
At the moment the bundle.props is assumed to be imported after all the users settings. Typically .props are imported at the top of the project and set the defaults.
This issue tracks:
- Determining which values can be defaults and move
- Move the property groups that still require to be processed at the end of the msbuild evaluation to the bundle.tarets file.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review bundle.props and bundle.targets, then inspect the merged pull request linked from this issue for prior work and decisions. Determine which property groups can be defaults and which must remain at the end of MSBuild evaluation; done means the appropriate groups are moved without changing required evaluation behavior.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100