microsoft / microsoft/react-native-windows
Extract JSConverter into a JSConverter.h file
Open
@vmoroz is already working on this.
Since Apr 7, 2020.
Area: Native Modules
Code Cleanup
enhancement
Workstream: Module Support
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
The JSConverter is added for value conversion in JSValue.cpp. The JSValueReader and JSValueWriter also need to do similar conversions, but currently they use different algorithms. It would beneficial that all conversions are done uniformly between these classes. E.g. there is special logic how to convert NaN to a string.
The change will require to move the JSConverter implementation into its own header file JSConverter.h and change JSValue, JSValueReader, and JSValueWriter to use this new class.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.