microsoft / microsoft/react-native-windows
Remove UnimplementedView Stubs for iOS and Android Specific Components
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
We have a number of stubs for iOS and Android specific components which just extend UnimplementView. We shouldn't need to have these, but upstream they are defined as platform specific. E.g. WidgetIOS.android.js instead of WidgetIOS.js. Facebook seemed onboard with making stubs the default in this case, so out-of-tree platforms can consume them. We should do that once on master so we don't need to maintain duplicate stubs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the iOS- and Android-specific component stubs that extend UnimplementedView, then compare them with the upstream platform-specific definitions described in the issue. Confirm the intended default-stub arrangement and remove the duplicate stubs so out-of-tree platforms can consume the defaults.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100