microsoft / microsoft/react-native-windows
JS integer literals are parsed into folly::dynamic ints on debug, doubles on release
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
This bug was found while writing the Camera Native Module.
For example: Method TakePicture() below:
REACT_METHOD(takePicture)
void takePicture(
std::map<std::wstring, winrt::Microsoft::ReactNative::JSValue>&& options,
int viewTag,
winrt::Microsoft::ReactNative::ReactPromise&& result) noexcept);
Options can contain a value pair such as {"target", 2}, when parsing the JSValue, 2 is Int64 in debug build but Double in Release build. I have to write a utility function to parse both types as a workaround.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the JSValue conversion used by REACT_METHOD(takePicture) for {"target", 2}, comparing debug and release behavior around folly::dynamic. Done means integer literals produce the same value type in both builds; add or run coverage for this example if the existing test path is found.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100