microsoft / microsoft/react-native-windows
Need to support firing touch and keyboard events for Video when it is full screen
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
This issue needs to be sovled in order to support react-native-video community module fully.
Issue is when MPE is in full screen mode, it is moved from its original place in the tree to under FullWindowMediaRoot. Since RNW relies on listening PreviewKeyEvent and TouchEvent on the react root element, it is no longer be able to get the events once MPE is in full window. There are similar issues for Popup and Flyout, we solved it by listening to these events directly on the element. We should do the same for MPE, with a bit more caution that events should be ignored when MPE is not in full screen mode to avoid firing events twice.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how FullWindowMediaRoot handles MPE, Popup, and Flyout input, especially PreviewKeyEvent and TouchEvent handling on the element versus the React root. Implement the analogous MPE event path with full-screen gating, then verify that keyboard and touch events fire in full screen without duplicate events outside it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- desktop, frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100