microsoft / microsoft/react-native-windows
Clean-up global maps and non POD objects
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
We have a number of std::map / std::unordered_map that map std::string to other things which require dynamic initializers/atexit destructors and make DLL load slower and bloatier. We should remove these.
Relevant guidance: https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inventorying the global std::map and std::unordered_map instances that map std::string to non-POD objects. Read the linked C++ guidance on static and global variables, then verify that the cleanup removes dynamic initializers and atexit destructors without changing behavior or DLL loading characteristics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100