microsoft / microsoft/react-native-windows
Alert: 'OK' text needs to be localized
Open
Nobody has claimed this yet.
Area: Alert
Area: Globalization
bug
Workstream: Component Parity
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
In the windows implementation of Alert, we currently have 'OK' hard-coded in English in the javascript. This should be localized. iOS does this on the native side, we should probably copy this pattern.
See vnext/src/libraries/alert/alert.windows.js
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with vnext/src/libraries/alert/alert.windows.js and compare how the issue says iOS handles the alert action text on the native side. Trace the existing localization path used by the Windows Alert implementation; done means the OK label is no longer hard-coded in English and displays localized text.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- localization
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100