microsoft / microsoft/react-native-windows
Add support for device orientation
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
RN4W is missing support for the "namedOrientationDidChange" event, which is supposed to be raised when the device orientation changes.
Currently, the Modal component uses this event, but apps are also free to subscribe to the event for other reasons.
See:
https://facebook.github.io/react-native/docs/modal#onorientationchange
https://facebook.github.io/react-native/docs/modal#supportedorientations
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the Modal component uses the namedOrientationDidChange event and compare that behavior with the linked React Native onOrientationChange and supportedOrientations documentation. Done means RN4W raises the event when device orientation changes and applications can subscribe to it outside Modal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100