microsoft / microsoft/react-native-windows
Bundle and entry point js leverage the same value
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
We write a cross platform app(Android, iOS, and Windows) that leverage the same entry point index.js at the moment.
But the suggested path for windows bundling in DebugBundle and ReleaseBundle is to bundle into "index.windows.bundle"
But these names are sourced from the same point (loadBundle)
std::shared_ptr<IReactInstance> reactInstance;
...
// name of entry point (index.js) but also name of bundle (index.bundle)
reactInstance->loadBundle(std::move("index"));
There should be some increased granularity and flexibility between defining an EntryPoint js and a bundle name.
Low pri. Can just generate index.bundle instead of index.windows.bundle and works fine for now.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing loadBundle and the DebugBundle and ReleaseBundle entry points that currently use the shared value for index.js and the bundle name. The issue names no files or tests; done means the JavaScript entry point and generated bundle name can be configured independently while preserving the existing index.bundle behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, javascript, react-native
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100