microsoft / microsoft/react-native-windows
Remove unicode conversion functions from def files.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Currently, both react-native-win32.dll and react.uwp.dll export Unicode conversion functions. This is due to older versions of react native's relying on non-standard Unicode conversions. The non-standard behavior has been removed, and we should remove those functions from the dll exports.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the def files that define exports for react-native-win32.dll and react.uwp.dll, then identify the Unicode conversion exports described in the issue. Done means those obsolete functions are absent from both DLL export lists; use the repository’s existing build or export checks to verify the change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100