microsoft / microsoft/react-native-windows
Suspending the expression animations that tie the module to the UI fails.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
See the comment in DisposeComplettedAnimations for more details.
Suspending the active expression animations while they are not in use causes subsequent key frame animations which target the providing property set to never fire their completed events. I can't explain this and for now and commenting out the code. Fixing this will prevent memory bloat as the current solutions never stops the expression animations that are built as a part of this animation solution.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with DisposeComplettedAnimations and its referenced comment, then trace how suspending active expression animations affects subsequent key frame animations targeting the providing property set. Reproduce the missing completed events and verify that the fix stops the expression animations without causing memory bloat.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100