microsoft / microsoft/react-native-windows
Networking: fetch/XHR GETs can silently return stale cached responses — default HttpBaseProtocolFilter never sets CacheControl.ReadBehavior
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Environment
- react-native-windows 0.83.2 (also present on
mainas of 2026-07-17), new architecture (Fabric, composition), Win32/HWND host - Windows 11 (WinINet/WinHTTP cache active)
- Reproduced in a production app against an authenticated JSON API
Steps to reproduce
- Have a backend endpoint that serves
GETresponses without aCache-Controlheader (very common for JSON APIs — many frameworks send none by default). - In a react-native-windows app,
fetch()that endpoint (anAuthorizationheader does not prevent the problem). - Change the data server-side (e.g. save an edit through a
POST/PUT), thenfetch()the sameGETURL again.
Expected
The second GET hits the network (or at least revalidates) and returns the updated data — matching the behavior of the same JS on React Native Android (OkHttp with no cache configured) and on browsers for heuristically-cacheable authenticated API responses.
Actual
The second GET returns the previous response body with an HTTP 200, with zero network I/O (confirmed: no request reaches the server). The OS HTTP cache (WinINet) answers the request using RFC 7234 heuristic caching, because nothing in the RNW networking stack opts out of cache reads. In our app this manifested as "saves silently revert": a screen re-fetched after a successful save and rendered the pre-save data.
Root cause
RedirectHttpFilter builds its inner filters as default-constructed HttpBaseProtocolFilters and only configures redirect/UI behavior — CacheControl().ReadBehavior is never set, so it stays at HttpCacheReadBehavior::Default, which permits serving cached entries without revalidation:
vnext/Shared/Networking/RedirectHttpFilter.cpp(currentmain):- Lines ~72–76:
RedirectHttpFilter(winrt::hstring defaultUserAgent)delegates withwinrt::Windows::Web::Http::Filters::HttpBaseProtocolFilter{}twice — default filters, default cache behavior. - Lines ~42–60: the designated constructor sets
AllowAutoRedirect(false)andAllowUI(false)on both inner filters but never touchesCacheControl().
- Lines ~72–76:
- Consumed by
WinRTHttpResource(vnext/Shared/Networking/WinRTHttpResource.cpp), which builds theHttpClientused for all JSfetch/XHR traffic.
The class already implements CacheControl() passthrough (RedirectHttpFilter.cpp ~line 117), so the plumbing exists — nothing ever calls it.
Suggested fix
In the RedirectHttpFilter constructor (next to the AllowAutoRedirect(false) calls), set:
baseFilter.CacheControl().ReadBehavior(winrt::Windows::Web::Http::Filters::HttpCacheReadBehavior::NoCache);
on both inner filters, which aligns RNW with React Native Android (OkHttp is configured with no HTTP cache, so JS-visible fetch semantics match across platforms). If disabling cache reads by default is considered too aggressive, at minimum expose a configuration knob (e.g. via IHttpModuleProxy/HttpSettings or a ReactPropertyBag property) so apps can opt out of WinINet cache reads — today there is no way to do this from app code short of cache-busting every URL.
Workaround (what we ship today)
- Server: middleware adding
Cache-Control: no-storeon all API GET responses. - Client (Windows only): axios/fetch interceptor appending a
_ts=<Date.now()>query parameter to every GET to defeat the WinINet cache key.
Both are required for apps that cannot control every backend; neither should be necessary.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in vnext/Shared/Networking/RedirectHttpFilter.cpp, reviewing the designated constructor, its default filter construction, and CacheControl() passthrough. Then trace how WinRTHttpResource.cpp builds the HttpClient and verify the behavior with repeated fetch/XHR GETs against responses without Cache-Control. Done means default GETs no longer silently serve stale cached responses and the existing redirect behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- api, networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 74/100