microsoft / microsoft/react-native-windows
Unfork NetworkIOAgent.cpp destructor and enableAgent API changes from 0.85 nightly integration
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Problem Description
During the integration of RN 0.85.0-nightly-20260128-36f07a1b2 (#16245), the upstream NetworkIOAgent API changed from enable()/disable() to enableAgent()/disableAgent(). A destructor was also added to properly clean up the network agent. These changes were applied to the existing override file.
Note: The existing override (tracked by #13587) covers type/namespace fixes. This issue tracks the new destructor and API adaptation.
Current Fix
Updated the existing patched copy at vnext/ReactCommon/TEMP_UntilReactCommonUpdate/jsinspector-modern/NetworkIOAgent.cpp with the destructor and new API calls.
Link to the integration PR where the error originated
#16245
Link to react-native commit
https://github.com/facebook/react-native/compare/f15985f4f...36f07a1b2
Forked files
No response
Upstream PR in react-native
No response
Build Configuration
None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with vnext/ReactCommon/TEMP_UntilReactCommonUpdate/jsinspector-modern/NetworkIOAgent.cpp and compare it with the React Native commit linked in the issue, using integration PR #16245 for context. Done means the override includes the destructor and uses enableAgent()/disableAgent() consistently with the upstream API.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100