microsoft / microsoft/react-native-windows
Unfork AnimatedPropSerializer.cpp override added during 0.85 nightly integration
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Problem Description
During the integration of RN 0.85.0-nightly-20260128-36f07a1b2 (#16245), the upstream AnimatedPropSerializer.cpp uses Color as a plain int32_t, but on Windows Color is a struct. This required a local patched copy with a helper function to convert Windows Color to int32_t ARGB format.
Current Fix
A local patched copy was created at vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/animationbackend/AnimatedPropSerializer.cpp with a colorToInt32() helper that calls color.AsWindowsColor().
Link to the integration PR where the error originated
#16245
Link to react-native commit
https://github.com/facebook/react-native/compare/f15985f4f...36f07a1b2
Forked files
No response
Upstream PR in react-native
No response
Build Configuration
None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/animationbackend/AnimatedPropSerializer.cpp and inspect the colorToInt32() helper and its Windows-specific conversion. Compare the file with the react-native commit linked from integration PR #16245, then verify that the local patched copy can be unforked once upstream supports Windows Color and the Windows integration build passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100