microsoft / microsoft/react-native-windows
Un fork TraceSection.h, CxxNativeModule.cpp
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Upstream changed the TRACE_TAG_REACT_APPS macro to TRACE_TAG_REACT.
However, we already weren't able to support the TRACE_TAG_REACT_APPS macro. See https://github.com/microsoft/react-native-windows/issues/14699 issue because it relies on something from Meta's internal build system.
So creating copy of this file and changing the macro back to TRACE_TAG_REACT_CXX_BRIDGE and added a comment to them "// [Windows]".
Link to the integration where the error originated
https://github.com/microsoft/react-native-windows/pull/14814
Forked files
vnext\ReactCommon\TEMP_UntilReactCommonUpdate\cxxreact\TraceSection.h
vnext\ReactCommon\TEMP_UntilReactCommonUpdate\cxxreact\CxxNativeModule.cpp
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with vnext\ReactCommon\TEMP_UntilReactCommonUpdate\cxxreact\TraceSection.h and CxxNativeModule.cpp, then compare them with the upstream commit linked in the issue. Preserve the Windows-specific macro handling and [Windows] comments, and verify the change against the integration context in pull request 14814.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- build-system, desktop
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100