microsoft / microsoft/react-native-windows
Implement JSRuntime enableSamplingProfiler, disableSamplingProfiler, and collectSamplingProfile
Open
@vmoroz is already working on this.
Since Jun 11, 2025.
Area: Debug Infrastructure
enhancement
Integration Follow-up
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Problem Description
Upstream added the following methods to their RuntimeAgent (see linked commits) and our HermesRuntimeHolder would need to implement these methods.
- enableSamplingProfiler
- disableSamplingProfiler
- collectSamplingProfile
Currently stubbed these methods out but unsure if we need a proper implementation
Link to the integration where the error originated
https://github.com/microsoft/react-native-windows/pull/14693
Link to commit
https://github.com/facebook/react-native/pull/48836/files
https://github.com/facebook/react-native/pull/48315/files
Forked files
Stub Methods in
- vnext/Shared/HermesRuntimeHolder.cpp
- vnext/Shared/HermesRuntimeHolder.h
- TEMP_UntilReactCommonUpdate/cxxreact/JSExecutor.cpp
- ReactCommon/TEMP_UntilReactCommonUpdate/cxxreact/JSExecutor.h
Upstream PR
N/A - we will need to implement in our code
Build Configuration
None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.