microsoft / microsoft/react-native-windows
JsiRuntime should disconnect to prevent users from holding on to it.
Open
@acoates-ms is already working on this.
Since May 14, 2025.
Area: JSI
enhancement
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Follow up from https://github.com/microsoft/react-native-windows/pull/14648.
The JsiRuntime that is handed out is not supposed to be held onto by the app. The JsiRuntime object that is passed out in events / from the CallInvoker should disconnect after the event/invoke call to prevent users from holding on to the object. In core this is passed to the app as a Runtime& which make it more clear that it shouldn't be held on to.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.