microsoft / microsoft/react-native-windows
Remove override of `NativeDOM.h`
A pull request for this has already been merged.
- #14650 by @anupriya13 — merged
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Problem Description
The 2/6 integration brought in a change which added some invalid characters that were breaking VS builds. Needed to fork the NativeDOM.h file to unblock the builds.
Link to the integration where the error originated
https://github.com/microsoft/react-native-windows/pull/14650
Link to commit
https://github.com/facebook/react-native/pull/49009
Forked files
vnext\ReactCommon\TEMP_UntilReactCommonUpdate\react\nativemodule\dom\NativeDOM.h
Upstream PR
TODO
Build Configuration
None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with vnext\ReactCommon\TEMP_UntilReactCommonUpdate\react\nativemodule\dom\NativeDOM.h and review the merged integration in pull request #14650, along with the linked upstream React Native change. Confirm that the upstream update makes the local override unnecessary, then remove the override and verify the Windows build no longer needs it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100