microsoft / microsoft/react-native-windows
Modal focus management: InputFocusNavigationHost::GetForSiteBridge fails on a DesktopPopupSiteBridge
Open
Nobody has claimed this yet.
Area: Focus
Area: Islands
Area: Modal
bug
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
There is currently an issue in WASDK which prevents us from getting InputFocusNavigationHost from a DesktopPopupSiteBridge. This means various parts of the Modal component's focus management is broken.
m_popUp = winrt::Microsoft::UI::Content::DesktopPopupSiteBridge::Create(
....
// This fails in current WASDK version
auto navHost =
winrt::Microsoft::UI::Input::InputFocusNavigationHost::GetForSiteBridge(m_popUp);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the call from DesktopPopupSiteBridge::Create to InputFocusNavigationHost::GetForSiteBridge. Confirm the failure and trace how it affects the Modal component's focus management; done means the navigation host can be obtained and modal focus behavior works as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- desktop-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100